Skip to content

[Python3] Fix test failures in update_checkout #33141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 28, 2020
Merged

[Python3] Fix test failures in update_checkout #33141

merged 3 commits into from
Jul 28, 2020

Conversation

tbkka
Copy link
Contributor

@tbkka tbkka commented Jul 27, 2020

Make the update_checkout tests pass for both Python 2 and Python 3.

@tbkka
Copy link
Contributor Author

tbkka commented Jul 27, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c7358fc

@tbkka
Copy link
Contributor Author

tbkka commented Jul 28, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - c7358fc

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - c7358fc

@tbkka
Copy link
Contributor Author

tbkka commented Jul 28, 2020

Both failures look entirely unrelated. Let's try again...

@tbkka
Copy link
Contributor Author

tbkka commented Jul 28, 2020

@swift-ci Please test

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 488a5ea

@tbkka
Copy link
Contributor Author

tbkka commented Jul 28, 2020

@swift-ci Please test macOS

@gottesmm
Copy link
Contributor

Thanks!

@tbkka tbkka merged commit 6187697 into swiftlang:master Jul 28, 2020
@tbkka tbkka deleted the tbkka/py3j branch October 16, 2020 00:32
@AnthonyLatsis AnthonyLatsis added the update-checkout Area → utils: the `update-checkout` script label Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compnerd compnerd compnerd approved these changes

Assignees
No one assigned
Labels
update-checkout Area → utils: the `update-checkout` script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tbkka @swift-ci @gottesmm @compnerd @AnthonyLatsis